smengcl commented on code in PR #3981:
URL: https://github.com/apache/ozone/pull/3981#discussion_r1035312646
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -362,6 +350,12 @@ private AbstractEventListener newCompactionBeginListener()
{
public void onCompactionBegin(RocksDB db,
CompactionJobInfo compactionJobInfo) {
+ // TODO: Skip (return) if no snapshot has been taken yet
+
+ // Note the current compaction listener implementation does not
+ // differentiate which column family each SST store. It is tracking
+ // all SST files.
Review Comment:
Filed HDDS-7559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]