smengcl commented on code in PR #4009:
URL: https://github.com/apache/ozone/pull/4009#discussion_r1035511985
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx:
##########
@@ -126,7 +126,7 @@ const COLUMNS = [
key: 'hostname',
isVisible: true,
isSearchable: true,
- sorter: (a: IDatanode, b: IDatanode) =>
a.hostname.localeCompare(b.hostname),
+ sorter: (a: IDatanode, b: IDatanode) =>
a.hostname.localeCompare(b.hostname,undefined,{numeric:true}),
Review Comment:
Note to self and others reviewing this: using `undefined` here defaults to
system locale.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/localeCompare#numeric_sorting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
