sodonnel commented on code in PR #4025: URL: https://github.com/apache/ozone/pull/4025#discussion_r1038005102
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/RatisUnderReplicationHandler.java: ########## @@ -0,0 +1,247 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.scm.container.replication; + +import org.apache.hadoop.hdds.conf.ConfigurationSource; +import org.apache.hadoop.hdds.conf.StorageUnit; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.ContainerReplicaProto.State; +import org.apache.hadoop.hdds.scm.PlacementPolicy; +import org.apache.hadoop.hdds.scm.ScmConfigKeys; +import org.apache.hadoop.hdds.scm.container.ContainerInfo; +import org.apache.hadoop.hdds.scm.container.ContainerReplica; +import org.apache.hadoop.hdds.scm.node.NodeManager; +import org.apache.hadoop.ozone.protocol.commands.ReplicateContainerCommand; +import org.apache.hadoop.ozone.protocol.commands.SCMCommand; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * This class handles Ratis containers that are under replicated. It should + * be used to obtain SCMCommands that can be sent to datanodes to solve + * under replication. + */ +public class RatisUnderReplicationHandler + implements UnhealthyReplicationHandler { + public static final Logger LOG = + LoggerFactory.getLogger(RatisUnderReplicationHandler.class); + private final PlacementPolicy placementPolicy; + private final NodeManager nodeManager; + private final long currentContainerSize; + + public RatisUnderReplicationHandler(final PlacementPolicy placementPolicy, + final ConfigurationSource conf, final NodeManager nodeManager) { + this.placementPolicy = placementPolicy; + this.currentContainerSize = (long) conf + .getStorageSize(ScmConfigKeys.OZONE_SCM_CONTAINER_SIZE, + ScmConfigKeys.OZONE_SCM_CONTAINER_SIZE_DEFAULT, StorageUnit.BYTES); + this.nodeManager = nodeManager; + } + + /** + * Identifies new set of datanodes as targets for container replication. + * Forms the SCMCommands to be sent to these datanodes. + * + * @param replicas Set of container replicas. + * @param pendingOps Pending ContainerReplicaOp including adds and deletes + * for this container. + * @param result Health check result indicating under replication. + * @param minHealthyForMaintenance Number of healthy replicas that must be + * available for a DN to enter maintenance + * + * @return Returns the key value pair of destination dn where the command gets + * executed and the command itself. If an empty map is returned, it indicates + * the container is no longer unhealthy and can be removed from the unhealthy + * queue. Any exception indicates that the container is still unhealthy and + * should be retried later. + */ + @Override + public Map<DatanodeDetails, SCMCommand<?>> processAndCreateCommands( + Set<ContainerReplica> replicas, List<ContainerReplicaOp> pendingOps, + ContainerHealthResult result, int minHealthyForMaintenance) Review Comment: Maybe we should leave as it is in this PR, and then remove it in a small cleanup PR afterwards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
