adoroszlai opened a new pull request, #4034: URL: https://github.com/apache/ozone/pull/4034
## What changes were proposed in this pull request? Pattern matching for jar version numbers in `update-jar-report.sh` does not correctly work for `ratis-*-2.4.2-8b8bdda-SNAPSHOT`. Expected: ``` share/ozone/lib/ratis-client.jar share/ozone/lib/ratis-common.jar share/ozone/lib/ratis-grpc.jar share/ozone/lib/ratis-metrics.jar share/ozone/lib/ratis-netty.jar share/ozone/lib/ratis-proto.jar share/ozone/lib/ratis-server-api.jar share/ozone/lib/ratis-server.jar ``` Actual: ``` share/ozone/lib/ratis-clientbdda-SNAPSHOT.jar share/ozone/lib/ratis-commonbdda-SNAPSHOT.jar share/ozone/lib/ratis-grpcbdda-SNAPSHOT.jar share/ozone/lib/ratis-metricsbdda-SNAPSHOT.jar share/ozone/lib/ratis-nettybdda-SNAPSHOT.jar share/ozone/lib/ratis-protobdda-SNAPSHOT.jar share/ozone/lib/ratis-server-apibdda-SNAPSHOT.jar share/ozone/lib/ratis-serverbdda-SNAPSHOT.jar ``` The problem is that `-[0-9]+(.[0-9]+)*` matches `-2.4.2-8b8` instead of `-2.4.2`, since `.` is "any char". We should only accept a literal `.`. https://issues.apache.org/jira/browse/HDDS-7581 ## How was this patch tested? ``` $ echo 'ratis-server-2.4.2-8b8bdda-SNAPSHOT.jar' \ | perl -wpl -e 's/-[0-9]+(\.[0-9]+)*(-([0-9a-z]+-)?SNAPSHOT)?+//g; s/\.v\d+\.jar/.jar/g;' ratis-server.jar ``` Also executed build and dependency check both for current `ratis-2.4.1` and for `ratis-2.4.2-8b8bddas-SNAPSHOT` (from HDDS-7555). https://github.com/adoroszlai/hadoop-ozone/actions/runs/3601990535/jobs/6068627412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
