sumitagrawl commented on PR #3225: URL: https://github.com/apache/ozone/pull/3225#issuecomment-1336844820
@kuenishi As solution in this PR, Every Request is having Key: timestamp+transactionId in deleted table and multiple keys are added to RepeatedOmKeyInfo. So one deletedKey have set of actual keys for deletion Impact: 1. keyLimitPerTask: In KeyDeletingService, this represents number of actual set of keys for deletion, now it will be set of request, which is further group of keys. This needs resolve. 2. Same case required for DirectoriesPurgeRequest where its deleting keys for recursive directory 3. I am not finding use case of adding timestamp, as transactionId is unique, I think should avoid duplicate request for same transactionId. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
