SaketaChalamchala commented on code in PR #4013:
URL: https://github.com/apache/ozone/pull/4013#discussion_r1040159937
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketArgs.java:
##########
@@ -150,11 +151,20 @@ public DefaultReplicationConfig
getDefaultReplicationConfig() {
return defaultReplicationConfig;
}
+ /**
+ * Returns true if defaultReplicationConfig has been set
+ * to a non default value.
+ */
+ public boolean hasDefaultReplicationConfig() {
Review Comment:
Thanks for the review @sodonnel. You're right,
`hasDefaultReplicationConfig()` is not needed in `OmBucketArgs`. `BucketArgs`
object already has a `hasDefaultReplicationConfig()` that we can use to
indicate if the replication config is set.
If the replication config needs to be "reset" i.e., removed from bucket
args, would it make sense to reuse null default replication config to indicate
both "to retain existing replication config" and "to reset to server default"?
Would another non null indicator be useful make the distinction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
