kuenishi commented on PR #3225: URL: https://github.com/apache/ozone/pull/3225#issuecomment-1338650992
> keyLimitPerTask: In KeyDeletingService, this represents number of actual set of keys for deletion, now it will be set of request, which is further group of keys. This needs resolve. > Same case required for DirectoriesPurgeRequest where its deleting keys for recursive directory OK, I've get your idea of appending object Id to the key in delete table. I'll split them into multiple entries in the delete table. > I am not finding use case of adding timestamp, as transactionId is unique, I think should avoid duplicate request for same transactionId. In case of non-HA setting, I saw a line of code comment saying that the transaction id is reset to 0 after the restart: https://github.com/apache/ozone/blob/de42c614a88c9ca9a082c12625f3dff12508b648/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/WithObjectID.java#L101 I added a timestamp prefix to address this issue of transaction id being reset to 0 (and we have a non-HA OM, which will be updated to 1.3.0 soon). Isn't this the case any more? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
