neils-dev commented on code in PR #4044: URL: https://github.com/apache/ozone/pull/4044#discussion_r1042534348
########## hadoop-ozone/dist/src/main/compose/ozone-grpc-om-s3/README.md: ########## @@ -0,0 +1,26 @@ +<!--- + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. See accompanying LICENSE file. +--> + +# Using gRPC between OM and S3G + +This is the same as `compose/ozone` but for testing operations with gRPC enabled Review Comment: > do we really need to have this as a separated docker-compose setup Not necessary, we can modify the existing dev cluster to only run our acceptance test when the cluster is configured to use s3g Grpc, specifically the `om.transport.class = org.apache.hadoop.ozone.om.protocolPB.GrpcOmTransportFactory`. The acceptance test for s3g metrics can be inserted into the existing dev clusters such as `compose/ozone`. Within the test, it needs to check if the `ozone-site` is configured for s3g Grpc such as, ``` ${result} = Execute And Ignore Error ozone getconf confKey om.transport.class ${contains} = Evaluate "GrpcOmTransport" in """${result}""" IF ${contains} == ${True} ``` run test. If the config is not set, then either do something else or do nothing. As @xBis7 mentioned, once the open PR to enable Grpc by default is merged and closed, the test will be run by default. Until then, it will be run when the user configures the dev cluster to use the `GrpcOmTransport`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
