adoroszlai opened a new pull request, #4059:
URL: https://github.com/apache/ozone/pull/4059

   ## What changes were proposed in this pull request?
   
   Move all dependency version definition to properties in root POM.  This 
allows overriding the dependency's version for each build.
   
   https://issues.apache.org/jira/browse/HDDS-7371
   
   ## How was this patch tested?
   
   Verified that all dependency versions are defined via properties, only 
enforcer rules have non-property-based `<version>` tags:
   
   ```
   $ rg '<version>' | grep -Fv -e '1.3.0-SNAPSHOT' -e '<version>${'
   pom.xml:                <version>[3.0.2,)</version>
   pom.xml:                <version>[1.8,)</version>
   ```
   
   Verified that dependency tree is same as for `master`:
   
   ```
   $ git checkout master
   $ mvn -Dorg.slf4j.simpleLogger.showDateTime=false -B --no-transfer-progress 
dependency:tree > dep.master
   $ git checkout HDDS-7371
   $ mvn -Dorg.slf4j.simpleLogger.showDateTime=false -B --no-transfer-progress 
dependency:tree > dep.HDDS-7371
   $ diff -uw dep.master dep.HDDS-7371
   --- dep.master       2022-12-08 10:08:39.198215059 +0100
   +++ dep.HDDS-7371    2022-12-08 10:08:41.990179382 +0100
   @@ -5080,52 +5080,52 @@
    [INFO] 
------------------------------------------------------------------------
    [INFO] Reactor Summary for Apache Ozone Main 1.3.0-SNAPSHOT:
    [INFO] 
   -[INFO] Apache Ozone Main .................................. SUCCESS [  
0.234 s]
   -[INFO] Apache Ozone HDDS .................................. SUCCESS [  
0.293 s]
   +[INFO] Apache Ozone Main .................................. SUCCESS [  
0.211 s]
   +[INFO] Apache Ozone HDDS .................................. SUCCESS [  
0.316 s]
   ...
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to