ChenSammi commented on code in PR #4032:
URL: https://github.com/apache/ozone/pull/4032#discussion_r1044060839
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java:
##########
@@ -198,7 +198,7 @@ protected NettyChannelBuilder createChannel(DatanodeDetails
dn, int port)
NettyChannelBuilder.forAddress(dn.getIpAddress(), port).usePlaintext()
.maxInboundMessageSize(OzoneConsts.OZONE_SCM_CHUNK_MAX_SIZE)
.intercept(new GrpcClientInterceptor());
- if (secConfig.isGrpcTlsEnabled()) {
+ if (secConfig.isSecurityEnabled() && secConfig.isGrpcTlsEnabled()) {
Review Comment:
> For the Om Grpc server and s3g client, we use enable TLS
(`secConf.isGrpcTlsEnabled()`) only with security enabled, otherwise it logs
the error a creates a Grpc "plaintext" channel. Similar checking for TLS
enabled and security as is here.
>
>
https://github.com/apache/ozone/blob/5db6fc50ba851d90871173b49d96991fe6f068dc/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/GrpcOzoneManagerServer.java#L101
Thanks @neils-dev for pointing out this space. It is going to be addressed
in my next patch [HDDS-7590](https://issues.apache.org/jira/browse/HDDS-7590)
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java:
##########
@@ -198,7 +198,7 @@ protected NettyChannelBuilder createChannel(DatanodeDetails
dn, int port)
NettyChannelBuilder.forAddress(dn.getIpAddress(), port).usePlaintext()
.maxInboundMessageSize(OzoneConsts.OZONE_SCM_CHUNK_MAX_SIZE)
.intercept(new GrpcClientInterceptor());
- if (secConfig.isGrpcTlsEnabled()) {
+ if (secConfig.isSecurityEnabled() && secConfig.isGrpcTlsEnabled()) {
Review Comment:
> For the Om Grpc server and s3g client, we use enable TLS
(`secConf.isGrpcTlsEnabled()`) only with security enabled, otherwise it logs
the error a creates a Grpc "plaintext" channel. Similar checking for TLS
enabled and security as is here.
>
>
https://github.com/apache/ozone/blob/5db6fc50ba851d90871173b49d96991fe6f068dc/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/GrpcOzoneManagerServer.java#L101
Thanks @neils-dev for pointing out this space. It is going to be addressed
in my next patch [HDDS-7590](https://issues.apache.org/jira/browse/HDDS-7590).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
