szetszwo commented on code in PR #4002:
URL: https://github.com/apache/ozone/pull/4002#discussion_r1044873554
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/SCMContainerPlacementRackScatter.java:
##########
@@ -81,6 +82,19 @@ public SCMContainerPlacementRackScatter(final NodeManager
nodeManager,
this.metrics = metrics;
}
+ /**
+ * Constructor for Pipeline Provider Pipeline Placement with rack awareness.
+ * @param nodeManager Node Manager
+ * @param stateManager State Manager
+ * @param conf Configuration
+ */
+ public SCMContainerPlacementRackScatter(NodeManager nodeManager,
+ PipelineStateManager stateManager, ConfigurationSource conf) {
Review Comment:
`PipelineStateManager` currently is unused in
`SCMContainerPlacementRackScatter`.
It is used in `PipelinePlacementPolicy` for counting pipelines in individual
datanodes so that it can choose a datanode with minimum existing pipelines. We
should do the same as a further improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
