jojochuang commented on code in PR #4060:
URL: https://github.com/apache/ozone/pull/4060#discussion_r1044875177
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##########
@@ -1323,28 +1323,27 @@ public boolean isNumber(String number) {
return true;
}
- FileStatus convertFileStatus(FileStatusAdapter fileStatusAdapter) {
- Path symLink = null;
- try {
- fileStatusAdapter.getSymlink();
- } catch (Exception ex) {
- //NOOP: If not symlink symlink remains null.
- }
-
- FileStatus fileStatus = new FileStatus(
- fileStatusAdapter.getLength(),
- fileStatusAdapter.isDir(),
- fileStatusAdapter.getBlockReplication(),
- fileStatusAdapter.getBlocksize(),
- fileStatusAdapter.getModificationTime(),
- fileStatusAdapter.getAccessTime(),
- new FsPermission(fileStatusAdapter.getPermission()),
- fileStatusAdapter.getOwner(),
- fileStatusAdapter.getGroup(),
- symLink,
- fileStatusAdapter.getPath()
+ protected FileStatus constructFileStatus(
+ FileStatusAdapter fileStatusAdapter) {
+ return new FileStatus(fileStatusAdapter.getLength(),
+ fileStatusAdapter.isDir(),
+ fileStatusAdapter.getBlockReplication(),
+ fileStatusAdapter.getBlocksize(),
+ fileStatusAdapter.getModificationTime(),
+ fileStatusAdapter.getAccessTime(),
+ new FsPermission(fileStatusAdapter.getPermission()),
+ fileStatusAdapter.getOwner(),
+ fileStatusAdapter.getGroup(),
+ fileStatusAdapter.getSymlink(),
+ fileStatusAdapter.getPath(),
+ false,
Review Comment:
This field is supposed to be a boolean "hasAcl".
This is unrelated, but I think once we are able to probe the external
authorization provider for its ACL, we will be able to implement this field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
