symious commented on PR #3908: URL: https://github.com/apache/ozone/pull/3908#issuecomment-1345292799
@ChenSammi Thank you for the work. I think it's a very good feature to have. Two things come to my mind: 1. The interface we are using is `check()`, but `compaction` seems more than a check operation since it's updating the rocksdb. 2. The performance issue might not be annoying, Users or Devs might not be easy to find their cluster slow caused by this operation. I was wondering if we don't do the compaction operation in `check()`, but only add a `need to compact` tag. Meanwhile, we can have a compaction thread doing the real compaction when Datanode is not busy so that the Datanode won't be affected by the compaction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
