Cyrill commented on code in PR #4041:
URL: https://github.com/apache/ozone/pull/4041#discussion_r1045290473


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyInputStream.java:
##########
@@ -136,288 +155,41 @@ public static List<LengthInputStream> 
getStreamsFromKeyInfo(OmKeyInfo keyInfo,
     // Create a KeyInputStream for each part.
     for (Map.Entry<Integer, List<OmKeyLocationInfo>> entry :
         partsToBlocksMap.entrySet()) {
-      KeyInputStream keyInputStream = new KeyInputStream();
-      keyInputStream.initialize(keyInfo, entry.getValue(),
-          xceiverClientFactory, verifyChecksum, retryFunction,
+      List<BlockExtendedInputStream> streams = createStreams(keyInfo,

Review Comment:
   I simplified the multipart case, replaced the whole calculation with a 
groupingBy collector. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to