siddhantsangwan commented on PR #3963: URL: https://github.com/apache/ozone/pull/3963#issuecomment-1346362939
> now, datanode will drop all the commands from an old scm leader. but i find there is a small problem. the scm leader term at datanoe is updated only before it is close to be handled. it means all the commands in the command queue from the stale scm leader will be handled until a command from new scm leader is handled. we should update the scm leader term at datanode when receiving a command, so that we can make sure those stale command will not be handled. Yes, good observation @JacksonYao287 . I think @sodonnel is already working on adding a timeout for dropping commands at the datanode which will cover this point too. Once that and https://github.com/apache/ozone/pull/4064 are committed, we can move things forward here too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
