[GitHub] [ozone] ArafatKhan2198 commented on a diff in pull request #4054: HDDS-7602. Adding metrics to display Pipeline leader Id's.

Mon, 12 Dec 2022 07:29:00 -0800 


ArafatKhan2198 commented on code in PR #4054:
URL: https://github.com/apache/ozone/pull/4054#discussion_r1045844335


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineManagerImpl.java:
##########
@@ -697,6 +698,28 @@ public Map<String, Integer> getPipelineInfo() throws 
NotLeaderException {
     return pipelineInfo;
   }
 
+  @Override
+  public Map<String, String[]> getPipelineLeaders() throws NotLeaderException {
+    final Map<String, String[]> pipelineInfo = new HashMap<>();
+    List<Pipeline> pipelines = getPipelines();
+    pipelines.forEach(pipeline -> {
+      String leaderNode = "";
+      UUID pipelineId = pipeline.getId().getId();
+
+      try {
+        leaderNode = pipeline.getLeaderNode().getHostName();

Review Comment:
   I followed a similar approach to how recon display's the Leader DataNode of 
the pipeline, by displaying the HostName, so I believe HostName should be 
alright
    
   <img width="571" alt="image" 
src="https://user-images.githubusercontent.com/98023601/207059287-da0723ec-7b43-4d7d-8cc1-1705cf891584.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to