sodonnel commented on code in PR #4061:
URL: https://github.com/apache/ozone/pull/4061#discussion_r1046000476
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/TestSCMCommonPlacementPolicy.java:
##########
@@ -76,17 +76,30 @@ private void testReplicasToFixMisreplication(
List<ContainerReplica> replicas,
DummyPlacementPolicy placementPolicy,
int expectedNumberOfReplicasToCopy,
- Map<Node, Integer> expectedNumberOfCopyOperationFromRack) {
+ Map<Node, Integer> expectedNumberOfCopyOperationFromRack)
Review Comment:
I might not see it, bit could we add a test to vaildate the new
functionality, which is not selecting replicas with "can copy" set to false.
Ideally we should test out the scenario where we cannot find enough to copy
too, and validate it does not fail but has partial success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
