errose28 commented on PR #4068: URL: https://github.com/apache/ozone/pull/4068#issuecomment-1347330662
Looks like appending the object ID as proposed is the only solution I can see. For key deletion we use the same key name but track multiple values with the same name in the proto, but directory deletion reuses the existing om key info proto for some reason. This was a pretty obvious mistake. Upgrades should be smooth as long as we get the object ID from the proto and don't try to get it by splitting the key path, since it won't be there for older deleted keys. Looks like the PR does this so it should be all set there. Do we dare ask for another 1.3.0 RC? Directories, files, and blocks could be orphaned in the cluster indefinitely if this is hit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
