smengcl commented on PR #4027: URL: https://github.com/apache/ozone/pull/4027#issuecomment-1347887567
Thanks @neils-dev for the draft PR! I read the description and the overall implementation sounds good to me. > Q. What to do with the Trash service on the shared tmp directory, currently executing delete commands with -skipTrash option. IIRC the current trash deleting service should have been already scanning every single bucket's hidden `.trash` folder. Hence I don't see why we need to worry about that here? I'm +1 on marking this ready for review. Note the minor conflict in `TestOzoneConfigurationFields`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
