sumitagrawl commented on PR #4093: URL: https://github.com/apache/ozone/pull/4093#issuecomment-1354214094
> I don't recall why I didn't use SystemClock, and instead created MonotonicClock. Perhaps I was trying to replace some calls to Time.monoticNow() that were originally there. Looks that way in the original PR: > > #2425 > > Strange it has taken so long for this to be noticed, as we have been using it for a long time. > > I wonder can we just replace all occurrences of MontonicClock with Java.time.SystemClock to fix this? As I have checked, SystemClock will give system time wrt January 1, 1970 UTC. The use will fix this problem. And MontonicClock will give time epoc wrt system start -- This will be useful to measure performance / time taken for a method @sodonnel @adoroszlai Do we need change the clock instance for this to SystemClock ? or replace MonotonicClock all places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
