siddhantsangwan commented on PR #3920:
URL: https://github.com/apache/ozone/pull/3920#issuecomment-1354546702
A side effect of this change is that Containers such as {Container State:
CLOSED, Replicas: CLOSED, CLOSING, CLOSING} would be called under replicated. I
saw that the handler will try to replicate only if closing these replicas won't
achieve sufficient replication. Do you think it can be confusing to call such a
container under replicated?
For EC in the new RM, we're treating UNHEALTHY replicas as "not there" since
they're unavailable, CLOSED as candidates for replicating, and replicas in
other states as available but cannot be replicated.
In `ECContainerReplicaCount`:
```
/*
Remove UNHEALTHY replicas because they are unavailable. They could be a
reason for under replication but should not be a reason for over
replication.
For example, consider the following set of replicas for an EC 3-2
container:
Replica Index 1: Closed
Replica Index 2: Closed
Replica Index 3: Closed, Unhealthy (2 replicas for this index)
Replica Index 4: Unhealthy
Replica Index 5: Closed
This is a case of under replication because index 4 is unavailable.
Index
3 is not considered over replicated because its second copy is
unhealthy.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
