errose28 commented on code in PR #4075:
URL: https://github.com/apache/ozone/pull/4075#discussion_r1052680368
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##########
@@ -480,9 +482,10 @@ public void stop() {
}
- private void terminate(IOException ex) {
+ private void terminate(IOException ex, OMResponse omResponse) {
String message = "During flush to DB encountered error in " +
- "OMDoubleBuffer flush thread " + Thread.currentThread().getName();
+ "OMDoubleBuffer flush thread " + Thread.currentThread().getName() +
+ " when handling OMRequest: " + omResponse;
Review Comment:
What string does this print for the OMResponse? I'm not sure it will
actually be the name of the response proto message.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##########
@@ -264,6 +264,7 @@ private Void addToBatchTransactionInfoWithTrace(String
parentName,
*/
private void flushTransactions() {
while (isRunning.get()) {
+ AtomicReference<OMResponse> omResponse = new AtomicReference<>();
Review Comment:
Why is this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
