sadanand48 commented on code in PR #4091:
URL: https://github.com/apache/ozone/pull/4091#discussion_r1052966829
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/response/s3/multipart/TestS3MultipartUploadAbortResponse.java:
##########
@@ -100,7 +100,8 @@ public void testAddDBToBatch() throws Exception {
protected S3InitiateMultipartUploadResponse
getS3InitiateMultipartUploadResponse(
String volumeName, String bucketName, String keyName,
- String multipartUploadID, long volumeId, long bucketId) {
+ String multipartUploadID, long volumeId, long bucketId)
+ throws IOException {
Review Comment:
Same comment as earlier.
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/response/s3/multipart/TestS3MultipartResponse.java:
##########
@@ -94,7 +94,7 @@ public void tearDown() {
public S3InitiateMultipartUploadResponse createS3InitiateMPUResponse(
String volumeName, String bucketName, String keyName,
- String multipartUploadID) {
+ String multipartUploadID) throws IOException {
Review Comment:
throws IOException not needed here.
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/response/s3/multipart/TestS3MultipartResponse.java:
##########
@@ -326,7 +330,7 @@ public S3MultipartUploadCompleteResponse
createS3CompleteMPUResponseFSO(
protected S3InitiateMultipartUploadResponse getS3InitiateMultipartUploadResp(
OmMultipartKeyInfo multipartKeyInfo, OmKeyInfo omKeyInfo,
- OMResponse omResponse, long volumeId, long bucketId) {
+ OMResponse omResponse, long volumeId, long bucketId) throws IOException {
Review Comment:
throws IOException not required here, only constructor is called below which
won't throw any exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
