smengcl commented on code in PR #4049:
URL: https://github.com/apache/ozone/pull/4049#discussion_r1054781287
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/recon/ReconConfigKeys.java:
##########
@@ -68,4 +68,7 @@ private ReconConfigKeys() {
public static final String OZONE_RECON_ADMINISTRATORS_GROUPS =
"ozone.recon.administrators.groups";
+
+ public static final String OZONE_RECON_TASK_SAFEMODE_WAIT_THRESHOLD
+ = "ozone.recon.task.safemode.wait.threshold";
Review Comment:
Should this be added to `ozone-default.xml`?
If not, at least add a comment describing how this is intended to be used.
What the default time unit is (seconds). So advanced users can tune it without
digging into the code.
Also it is missing the default value const, which should be `300`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
