xBis7 commented on PR #4140: URL: https://github.com/apache/ozone/pull/4140#issuecomment-1370223123
@kerneltime Thanks for looking into this. > Why the need to format the metric as I wanted to avoid duplicating code, so I got the same string we are using in `OMMXBean.getRatisRoles()` from `OzoneManager.getRatisRoles()`. We can either split it up in new tags or have a Map and then use that for the tag. > Would it make sense to break it up into individual values so it can be charted? We want to track the leader and if we are presenting info only for the current node, then we would have to go over all of them just to find the leader. If you want to simplify it, we could have a tag with only the info for the leader and skip all the followers. Do you have any suggestions about the format? This fix is based on this [discussion](https://github.com/apache/ozone/pull/3781#discussion_r1001614335) and #3791. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
