errose28 commented on code in PR #4051:
URL: https://github.com/apache/ozone/pull/4051#discussion_r1061074956


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java:
##########
@@ -290,8 +289,6 @@ public static OMClientRequest createClientRequest(OMRequest 
omRequest,
       volumeName = keyArgs.getVolumeName();
       bucketName = keyArgs.getBucketName();
       break;
-    case EchoRPC:

Review Comment:
   While we don't need this here we should probably add it to 
`OmUtils#isReadOnly`.



##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java:
##########
@@ -290,8 +289,6 @@ public static OMClientRequest createClientRequest(OMRequest 
omRequest,
       volumeName = keyArgs.getVolumeName();
       bucketName = keyArgs.getBucketName();
       break;
-    case EchoRPC:
-      return new OMEchoRPCRequest(omRequest);

Review Comment:
   We can delete the `OmEchoRPCRequest` class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to