[ 
https://issues.apache.org/jira/browse/HDDS-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654480#comment-17654480
 ] 

Christos Bisias edited comment on HDDS-7506 at 1/5/23 1:39 PM:
---------------------------------------------------------------

[~smeng] The number of active snapshots can't be a counter because the status 
might change to deleted or reclaimed and the metric should be able to keep up 
with the change.

The best way seems to go over the snapshot table and check the status for every 
snapshot and then update the metrics. Counting the number of active snapshots 
just for the metrics, seems like an unnecessary load for the system if it has 
to happen periodically.

What do you think?


was (Author: JIRAUSER285705):
[~smeng] The number of active snapshots can't be a counter because the status 
might change to deleted or reclaimed and the metric should be able to keep up 
with the change.

The best way seems to go over the snapshot table and check the status for every 
snapshot and then update the metrics. Counting the number of active snapshots 
just for the metrics, seems like an unnecessary load for the system.

What do you think?

> Expose more snapshot metrics under OMMetrics
> --------------------------------------------
>
>                 Key: HDDS-7506
>                 URL: https://issues.apache.org/jira/browse/HDDS-7506
>             Project: Apache Ozone
>          Issue Type: Sub-task
>            Reporter: Siyao Meng
>            Assignee: Christos Bisias
>            Priority: Major
>
> Investigate and add any missing snapshot metrics that are useful to the end 
> user or monitoring agents. See {{OMMetrics}}.
> Related discussion on another PR: 
> https://github.com/apache/ozone/pull/3784#discussion_r1025882801



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to