errose28 commented on PR #4075: URL: https://github.com/apache/ozone/pull/4075#issuecomment-1372876050
> I added the whole stacktrace, I think the exception is thrown in the for loop, so the omResponse can still hold the information? Right, the exception is thrown in the loop, but it is not caught until the outer try/catch, where the response has gone out of scope in the original code. Instead of changing the scope of the response, we can add a more generic catch inside the loop as well. The try/catch inside the loop would handle exceptions related to applying that specific response. The outer try/catch would handle general state machine exceptions, like committing the whole batch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
