GeorgeJahad commented on code in PR #4134:
URL: https://github.com/apache/ozone/pull/4134#discussion_r1062999942
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java:
##########
@@ -603,12 +605,24 @@ public FileStatusAdapter getFileStatus(String path, URI
uri,
if (ofsPath.isRoot()) {
return getFileStatusAdapterForRoot(uri);
}
+
+ OzoneVolume volume = objectStore.getVolume(ofsPath.getVolumeName());
Review Comment:
I'm guessing this line was moved here out of the if statement below because
it is needed elsewhere. That is often a good idea, but I think I remember
people saying they were concerned about the performance of getFileStatus(), so
I would leave it where it was and invoke it again from within the
```
if (ofsPath.isSnapshotPrefix()) {
```
block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
