smengcl commented on code in PR #4027:
URL: https://github.com/apache/ozone/pull/4027#discussion_r1063684454
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OFSPath.java:
##########
@@ -63,16 +66,19 @@ public class OFSPath {
private String bucketName = "";
private String mountName = "";
private String keyName = "";
+ private OzoneConfiguration conf;
private static final String OFS_MOUNT_NAME_TMP = "tmp";
// Hard-code the volume name to tmp for the first implementation
@VisibleForTesting
public static final String OFS_MOUNT_TMP_VOLUMENAME = "tmp";
- public OFSPath(Path path) {
Review Comment:
One way to avoid changing every single existing usage is to keep the old
constructor:
```
public OFSPath(Path path) {
this.conf = new OzoneConfiguration();
initOFSPath(path.toUri(), false);
}
```
Or even just `this.conf = null;`, given proper handling (null check).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
