ChenSammi commented on code in PR #3648:
URL: https://github.com/apache/ozone/pull/3648#discussion_r1064284005
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -381,13 +381,16 @@ ContainerCommandResponseProto handleCreateContainer(
return getSuccessResponse(request);
}
- private void populateContainerPathFields(KeyValueContainer container)
- throws IOException {
+ private void populateContainerPathFields(KeyValueContainer container,
+ HddsVolume hddsVolume) throws IOException {
volumeSet.readLock();
+ HddsVolume containerVolume = hddsVolume;
try {
- HddsVolume containerVolume = volumeChoosingPolicy.chooseVolume(
- StorageVolumeUtil.getHddsVolumesList(volumeSet.getVolumesList()),
- container.getContainerData().getMaxSize());
+ if (hddsVolume == null) {
Review Comment:
hddsVolume should not be null here. We need to make sure that in
container.importContainerData, tmpDir and
DownloadAndImportReplicator.getUntarDirectory(hddsVolume) are on the same
volume.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
