swamirishi commented on code in PR #4014:
URL: https://github.com/apache/ozone/pull/4014#discussion_r1064597828
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/TestSCMCommonPlacementPolicy.java:
##########
@@ -286,6 +288,102 @@ public void testReplicasWithoutMisreplication() {
Assertions.assertEquals(0, replicasToCopy.size());
}
+ @Test
+ public void testReplicasToRemoveWithOneOverreplication() {
+ DummyPlacementPolicy dummyPlacementPolicy =
+ new DummyPlacementPolicy(nodeManager, conf, 5);
+ List<DatanodeDetails> list = nodeManager.getAllNodes();
+ Set<ContainerReplica> replicas = Sets.newHashSet(
+ HddsTestUtils.getReplicasWithReplicaIndex(
+ new ContainerID(1), CLOSED, 0, 0, 0, list.subList(1, 6)));
+ ContainerReplica replica = ContainerReplica.newBuilder()
+ .setContainerID(new ContainerID(1))
+ .setContainerState(CLOSED)
+ .setReplicaIndex(1)
+ .setDatanodeDetails(list.get(7)).build();
+ replicas.add(replica);
+
+ Set<ContainerReplica> replicasToRemove = dummyPlacementPolicy
+ .replicasToRemoveToFixOverreplication(replicas, 1);
+ Assertions.assertEquals(replicasToRemove.size(), 1);
+ Assertions.assertEquals(replicasToRemove.stream().findFirst().get(),
+ replica);
+ }
+
+ @Test
+ public void testReplicasToRemoveWithTwoOverreplication() {
+ DummyPlacementPolicy dummyPlacementPolicy =
+ new DummyPlacementPolicy(nodeManager, conf, 5);
+ List<DatanodeDetails> list = nodeManager.getAllNodes();
+
+ Set<ContainerReplica> replicas = Sets.newHashSet(
+ HddsTestUtils.getReplicasWithReplicaIndex(
+ new ContainerID(1), CLOSED, 0, 0, 0, list.subList(1, 6)));
+
+ Set<ContainerReplica> replicasToBeRemoved = Sets.newHashSet(
+ HddsTestUtils.getReplicasWithReplicaIndex(
+ new ContainerID(1), CLOSED, 0, 0, 0, list.subList(7, 9)));
+ replicas.addAll(replicasToBeRemoved);
+
+ Set<ContainerReplica> replicasToRemove = dummyPlacementPolicy
+ .replicasToRemoveToFixOverreplication(replicas, 1);
+ Assertions.assertEquals(replicasToRemove.size(), 2);
+ Assertions.assertEquals(replicasToRemove, replicasToBeRemoved);
Review Comment:
Other racks contain only 1 replica. The replicas are removed from racks
containing the max replica. In this Dn7 & Dn9 belong to rack2 & rack4. The
initial set of replicas are spread across 5 racks.
Only rack2 & rack4 have 2 replicas of replica Index 1 in them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
