xBis7 commented on code in PR #3741:
URL: https://github.com/apache/ozone/pull/3741#discussion_r1064699917
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/ozone/container/common/TestEndPoint.java:
##########
@@ -105,20 +116,13 @@ public static void setUp() throws Exception {
scmServer = SCMTestUtils.startScmRpcServer(SCMTestUtils.getConf(),
scmServerImpl, serverAddress, 10);
testDir = PathUtils.getTestDir(TestEndPoint.class);
- config = SCMTestUtils.getConf();
- config.set(DFS_DATANODE_DATA_DIR_KEY, testDir.getAbsolutePath());
- config.set(OZONE_METADATA_DIRS, testDir.getAbsolutePath());
- config
- .setBoolean(OzoneConfigKeys.DFS_CONTAINER_RATIS_IPC_RANDOM_PORT, true);
- config.set(HddsConfigKeys.HDDS_COMMAND_STATUS_REPORT_INTERVAL, "1s");
- config.setFromObject(new ReplicationConfig().setPort(0));
Review Comment:
@errose28 `config` field was never getting used. The tests that actually
need these confs, are setting them under their scope and never using `config`.
The majority of the tests don't need them, so it made most sense to get rid of
`config` altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
