adoroszlai commented on code in PR #4150:
URL: https://github.com/apache/ozone/pull/4150#discussion_r1065017754
##########
hadoop-ozone/dist/src/main/compose/ozone-ha/docker-compose.yaml:
##########
@@ -103,7 +103,7 @@ services:
httpfs:
<<: *common-config
environment:
- OZONE_CLASSPATH:
"/opt/hadoop/share/ozone/lib/ozone-filesystem-1.3.0-SNAPSHOT.jar:/opt/hadoop/share/ozone/lib/ozone-filesystem-common-1.3.0-SNAPSHOT.jar:/opt/hadoop/share/ozone/lib/ozone-filesystem-hadoop3-1.3.0-SNAPSHOT.jar"
+ OZONE_CLASSPATH:
"/opt/hadoop/share/ozone/lib/ozone-filesystem-${ozone.version}.jar:/opt/hadoop/share/ozone/lib/ozone-filesystem-common-${ozone.version}.jar:/opt/hadoop/share/ozone/lib/ozone-filesystem-hadoop3-${ozone.version}.jar"
Review Comment:
The `ozone-filesystem-hadoop3` jar has all classes from the other two jars,
it can be used in itself.
```suggestion
OZONE_CLASSPATH:
"/opt/hadoop/share/ozone/lib/ozone-filesystem-hadoop3-${ozone.version}.jar"
```
##########
hadoop-ozone/dist/src/main/compose/ozonesecure-ha/test.sh:
##########
@@ -39,8 +39,7 @@ execute_robot_test ${SCM} s3
execute_robot_test ${SCM} admincli
-# commented out until httpfs user and group is added to ozone-docker-runner
-# execute_robot_test ${SCM} -v SECURITY_ENABLED:${SECURITY_ENABLED} httpfs
+execute_robot_test ${SCM} -v SECURITY_ENABLED:${SECURITY_ENABLED} httpfs
Review Comment:
`-v SECURITY_ENABLED:${SECURITY_ENABLED}` is already part of the artguments
passed to `robot` in `execute_robot_test`:
https://github.com/apache/ozone/blob/a80c6b1c73b01660e067ba1c30e055522fd1fdfb/hadoop-ozone/dist/src/main/compose/testlib.sh#L188-L196
So I think it can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
