dombizita commented on code in PR #4042:
URL: https://github.com/apache/ozone/pull/4042#discussion_r1065640509
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/LegacyBucketHandler.java:
##########
@@ -322,4 +323,11 @@ public Table<String, OmKeyInfo> getKeyTable() {
getOmMetadataManager().getKeyTable(getBucketLayout());
return keyTable;
}
+
+ @Override
+ public OmDirectoryInfo getDirInfo(String[] names) throws IOException {
+ return OmDirectoryInfo.newBuilder()
+ .setName(names[2])
Review Comment:
I get that currently this is only called when it is guaranteed that the path
is a directory. but if someone later adds something and doesn't know how this
method works the scenario can happen which @smengcl wrote above. all the
classes that are extending the `EntityHandler` abstract class can do a
`OmDirectoryInfo omDirectoryInfo = getBucketHandler().getDirInfo(names)`, even
if the `names` length is less than 3. I am also fine with either way, just
wanted to clarify what I meant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
