fapifta commented on code in PR #4138:
URL: https://github.com/apache/ozone/pull/4138#discussion_r1067467377
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -459,6 +459,7 @@ private OzoneManager(OzoneConfiguration conf, StartupOption
startupOption)
this.omNodeDetails = omhaNodeDetails.getLocalNodeDetails();
omStorage = new OMStorage(conf);
+ omStorage.validateOrPersistOmNodeId(omNodeDetails.getNodeId());
Review Comment:
Oh, one more thing...
I went ahead and tried to add an UpgradeAction, but once I started I quickly
realized the following:
UpgradeActions are running pretty much after Ozone Manager was initialized
almost fully, in the start() method, it seems to be pretty late to fail, and
the impacts of moving the initialization of the value in the storage or the
validation to that late are not clear, so it is at least risky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
