ArafatKhan2198 commented on code in PR #4107:
URL: https://github.com/apache/ozone/pull/4107#discussion_r1070858951
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconStaleNodeHandler.java:
##########
@@ -50,6 +55,7 @@ public void onMessage(final DatanodeDetails datanodeDetails,
super.onMessage(datanodeDetails, publisher);
try {
pipelineSyncTask.triggerPipelineSyncTask();
+ containerSizeCountTask.process(containerManager.getContainers());
Review Comment:
The main function of the stale node handler is to ensure that the data
stored in the pipelines associated with the stale node is not accessible
anymore and also log the information about the stale node.
**Hence, since neither containers or their replicas are removed, the
container size counts will not be affected. Therefore, we would not have to
trigger the ContainerSizeCountTask.**
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconIncrementalContainerReportHandler.java:
##########
@@ -99,5 +103,6 @@ public void onMessage(final
IncrementalContainerReportFromDatanode report,
}
}
containerManager.notifyContainerReportProcessing(false, success);
+ containerSizeCountTask.process(containerManager.getContainers());
Review Comment:
Since If the container does not exist, it creates a new container and adds
it to the ContainerManager hence we will have to trigger the
ContainerSizeCountTask.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
