kaijchen commented on code in PR #4177:
URL: https://github.com/apache/ozone/pull/4177#discussion_r1070908573
##########
hadoop-hdds/common/src/main/resources/hdds-version-info.properties:
##########
@@ -25,4 +25,5 @@ url=${version-info.scm.uri}
srcChecksum=${version-info.source.md5}
hadoopProtoc2Version=${proto2.hadooprpc.protobuf.version}
hadoopProtoc3Version=${proto3.hadooprpc.protobuf.version}
-grpcProtocVersion=${grpc.protobuf-compile.version}
\ No newline at end of file
+grpcProtocVersion=${grpc.protobuf-compile.version}
+platform=${os.detected.classifier}
Review Comment:
Looks like this value is defined in compile time.
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/HddsVersionInfo.java:
##########
@@ -52,6 +52,8 @@ public static void main(String[] args) {
" and " + HDDS_VERSION_INFO.getHadoopProtoc3Version());
System.out.println(
"From source with checksum " + HDDS_VERSION_INFO.getSrcChecksum());
+ System.out.println(
+ "For platform " + HDDS_VERSION_INFO.getPlatform());
Review Comment:
Correct me if I'm wrong, I don't think the current Ozone binary package is
platform specific.
If it's true, we should give information like "compiled on x86_64", but not
"compiled for x86_64".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
