navinko commented on PR #3943:
URL: https://github.com/apache/ozone/pull/3943#issuecomment-1384452890
Hi @errose28 @ChenSammi I am apologize for getting delayed.
The test case failure is fixed now and the issue was the command options
should supposed to be unique one. While reusing the options --id in Scmoption
calss and ListInfoSubcommand class it was resulting into
DuplicateOptionAnnotationsException in test cases.
picocli.CommandLine$DuplicateOptionAnnotationsException: Option name '--id'
is used by both field String
org.apache.hadoop.hdds.scm.cli.datanode.ListInfoSubcommand.uuid and field
String org.apache.hadoop.hdds.scm.cli.ScmOption.scmServiceId
To fix the issue for now i did not change the --id to --uuid in
ListInfoSubcommand class since this might be breaking change for existing
commands , instead added --uuid option in ListInfoSubcommand for eventually
addition and --id removal
@CommandLine.Option(names = {"--id", "--uuid"}
and under Scmoption class left it as it is for now @CommandLine.Option(names
= {"--service-id", "-id"} and later will be added --id
Let me know if there is any concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
