smengcl commented on code in PR #4185:
URL: https://github.com/apache/ozone/pull/4185#discussion_r1080672782
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshot.java:
##########
@@ -215,6 +225,12 @@ private OzoneFileStatus denormalizeOzoneFileStatus(
omKeyInfo, fileStatus.getBlockSize(), fileStatus.isDirectory());
}
+ private KeyInfoWithVolumeContext denormalizeKeyInfoWithVolumeContext(
+ KeyInfoWithVolumeContext k) {
+ return new KeyInfoWithVolumeContext(k.getVolumeArgs().orElse(null),
Review Comment:
Would using its `Builder` be better than calling the constructor directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
