adoroszlai commented on code in PR #4097:
URL: https://github.com/apache/ozone/pull/4097#discussion_r1082278336
##########
hadoop-ozone/dist/src/main/license/jar-report.txt:
##########
@@ -37,23 +38,24 @@ share/ozone/lib/disruptor.jar
share/ozone/lib/dnsjava.jar
share/ozone/lib/error_prone_annotations.jar
share/ozone/lib/failureaccess.jar
-share/ozone/lib/FastInfoset.jar
share/ozone/lib/gethostname4j.jar
share/ozone/lib/grpc-api.jar
share/ozone/lib/grpc-context.jar
share/ozone/lib/grpc-core.jar
share/ozone/lib/grpc-netty.jar
-share/ozone/lib/grpc-protobuf.jar
share/ozone/lib/grpc-protobuf-lite.jar
+share/ozone/lib/grpc-protobuf.jar
share/ozone/lib/grpc-stub.jar
share/ozone/lib/gson.jar
share/ozone/lib/guava-jre.jar
share/ozone/lib/guice-assistedinject.jar
share/ozone/lib/guice-bridge.jar
-share/ozone/lib/guice.jar
share/ozone/lib/guice-multibindings.jar
share/ozone/lib/guice-servlet.jar
+share/ozone/lib/guice.jar
share/ozone/lib/hadoop-annotations.jar
+share/ozone/lib/hadoop-annotations.jar
+share/ozone/lib/hadoop-auth.jar
share/ozone/lib/hadoop-auth.jar
Review Comment:
Duplicate entries are present due to different jar versions for Hadoop 2 and
3. We should not be including jars from Hadoop 2 in the Ozone distribution.
##########
hadoop-ozone/dist/src/main/license/jar-report.txt:
##########
@@ -1,10 +1,11 @@
+share/ozone/lib/FastInfoset.jar
Review Comment:
There still are unnecessarily reordered lines. On closer look, no changes
should be done in the jar report.
##########
hadoop-ozone/dist/pom.xml:
##########
@@ -105,6 +105,16 @@
<artifactId>protobuf-java</artifactId>
<version>${grpc.protobuf-compile.version}</version>
</artifactItem>
+ <artifactItem>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-auth</artifactId>
+ <version>${hadoop2.version}</version>
+ </artifactItem>
+ <artifactItem>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-annotations</artifactId>
+ <version>${hadoop2.version}</version>
+ </artifactItem>
Review Comment:
We should not copy Hadoop2 jars to `share/ozone/lib`. These are expected to
be provided by users who wish to use Ozone in a Hadoop2 environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
