aryangupta1998 commented on code in PR #4182:
URL: https://github.com/apache/ozone/pull/4182#discussion_r1083709781
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerEndpoint.java:
##########
@@ -157,11 +157,17 @@ public Response getKeysForContainer(
for (ContainerKeyPrefix containerKeyPrefix : containerKeyPrefixMap
.keySet()) {
- // Directly calling get() on the Key table instead of iterating since
- // only full keys are supported now. When we change to using a prefix
- // of the key, this needs to change to prefix seek.
- OmKeyInfo omKeyInfo = omMetadataManager.getKeyTable(getBucketLayout())
- .getSkipCache(containerKeyPrefix.getKeyPrefix());
+ // Directly calling get() on the Key table instead of iterating since
Review Comment:
Actually, we are calling 'getSkipCache()' not 'get()' and we aren't calling
the function directly on the key table rather we are deciding the table i.e,
file table or key table based on the bucket layout, maybe you can update the
comment accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
