xBis7 commented on code in PR #4134:
URL: https://github.com/apache/ozone/pull/4134#discussion_r1085378856


##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java:
##########
@@ -643,6 +645,13 @@ public FileStatusAdapter getFileStatus(String path, URI 
uri,
     }
     try {
       OzoneBucket bucket = getBucket(ofsPath, false);
+
+      if (ofsPath.isSnapshotIndicator()) {

Review Comment:
   I think it's worth keeping the try catch, in order to have a more specific 
error message in case of failure. It's gonna look like so 
   
   ```suggestion
         if (ofsPath.isRoot()) {
           ...
         } else if (ofsPath.isVolume()) {
           ...
         } else {
           try {
             if (ofsPath.isSnapshotIndicator()) {
               ...
             } else {
               ...
             }
           } catch () {
             ...
           } 
         }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to