xBis7 commented on code in PR #4125:
URL: https://github.com/apache/ozone/pull/4125#discussion_r1085531016
##########
hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneAddress.java:
##########
@@ -47,26 +48,34 @@ public static Collection<Object[]> data() {
});
}
- private String prefix;
+ @Rule
+ public ExpectedException exception = ExpectedException.none();
+
+ private final String prefix;
+ private OzoneAddress address;
public TestOzoneAddress(String prefix) {
this.prefix = prefix;
}
@Test
- public void checkUrlTypes() throws OzoneClientException, IOException {
- OzoneAddress address;
-
+ public void checkRootUrlType() throws OzoneClientException {
address = new OzoneAddress("");
Review Comment:
One is referring to the ozone scheme prefix and the other one to the entity
level(root, volume, bucket, etc). In this case there is no difference, check
[here](https://github.com/apache/ozone/blob/a20e84ef03517d8970d8094cd4ec85d3d53caee2/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/OzoneAddress.java#L70),
but we need this call to initialize `OzoneAddress`, even if we are setting an
empty address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
