smengcl commented on PR #4148: URL: https://github.com/apache/ozone/pull/4148#issuecomment-1402462990
> Thanks @jyotirmoy-gh for the patch, looks good overall. Although I'm not sure if we should call it 'restore' as here we are copying from snapshot to active DB and new blocks for the new keys would be written again whereas during actual restore only metadata must be added back to the Active rocksdb, but I guess we would need to change this file when actual snapshot restore is implemented. @smengcl any thoughts? Thanks @sadanand48 for the comment. I'm actually fine with the "restore" name. `TestOzoneSnapshotRead` might be more accurate, but too vague by itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
