prashantpogde commented on code in PR #4214:
URL: https://github.com/apache/ozone/pull/4214#discussion_r1089398388
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBCheckpointManager.java:
##########
@@ -85,6 +87,8 @@ public RocksDBCheckpoint createCheckpoint(String parentDir,
String name) {
LOG.info("Created checkpoint at {} in {} milliseconds",
checkpointPath, duration);
+ waitForCheckpointDirectoryExist(checkpointPath.toFile());
+
return new RocksDBCheckpoint(
checkpointPath,
currentTime,
Review Comment:
I believe checkpoint object returned should still be valid if the rocksDB
api returned success. However, we should throw the timeout exception all the
way back to the application. Application can wait for the snapshot dir creation
when this happens before using the snapshot dir. The exception thrown should
contain enough details so that application can wait on the dir creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
