GeorgeJahad commented on code in PR #4190:
URL: https://github.com/apache/ozone/pull/4190#discussion_r1089564790


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -268,4 +280,29 @@ private void verifySnapshotInfoForSnapDiff(final 
SnapshotInfo fromSnapshot,
           " should be older than to toSnapshot:" + toSnapshot.getName());
     }
   }
+
+  private RocksDB createRocksDbForSnapshotDiff(OzoneConfiguration config) {

Review Comment:
   It seems like this new rocksdb should not be included when bootstraping a 
follower, is that right?
   



##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -268,4 +280,29 @@ private void verifySnapshotInfoForSnapDiff(final 
SnapshotInfo fromSnapshot,
           " should be older than to toSnapshot:" + toSnapshot.getName());
     }
   }
+
+  private RocksDB createRocksDbForSnapshotDiff(OzoneConfiguration config) {

Review Comment:
   It seems like this new rocksdb should not be included when bootstrapping a 
follower, is that right?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to