symious commented on code in PR #2424:
URL: https://github.com/apache/ozone/pull/2424#discussion_r1090227083
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java:
##########
@@ -307,9 +309,27 @@ public OMClientResponse handleWriteRequest(OMRequest
omRequest,
OMClientResponse omClientResponse = null;
omClientRequest =
OzoneManagerRatisUtils.createClientRequest(omRequest, impl);
- omClientResponse = omClientRequest
- .validateAndUpdateCache(getOzoneManager(), transactionLogIndex,
- ozoneManagerDoubleBuffer::add);
+ try {
+ omClientResponse = omClientRequest
+ .validateAndUpdateCache(getOzoneManager(), transactionLogIndex,
+ ozoneManagerDoubleBuffer::add);
+ } catch (InvalidPathException e) {
+ OMException omException = new OMException(e.getMessage(),
+ OMException.ResultCodes.INVALID_PATH);
+ OMResponse.Builder omResponse =
+ OmResponseUtil.getOMResponseBuilder(omRequest);
+ omResponse.setSuccess(false);
+ omResponse.setMessage(omException.getMessage());
+ omResponse.setStatus(OzoneManagerRatisUtils.exceptionToResponseStatus(
+ omException));
+ omClientResponse =
+ new InvalidPathClientResponse(omResponse.build());
+ if (omClientResponse.getFlushFuture() == null) {
+ omClientResponse.setFlushFuture(
+ ozoneManagerDoubleBuffer.add(omClientResponse,
+ transactionLogIndex));
Review Comment:
There was a inconsistence of the transactionId among the OMs, followers have
problem starting without these lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
