kerneltime commented on code in PR #3908:
URL: https://github.com/apache/ozone/pull/3908#discussion_r1090229268
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -364,6 +364,31 @@ public void setWaitOnAllFollowers(boolean val) {
)
private int rocksdbMaxOpenFiles = ROCKSDB_MAX_OPEN_FILES_DEFAULT;
+ @Config(key = "rocksdb.auto-compaction-small-sst-file",
+ defaultValue = "true",
+ type = ConfigType.BOOLEAN,
+ tags = { DATANODE },
+ description = "Auto compaction small sst files when condition is met. "
Review Comment:
```suggestion
description = "Auto compact small SST files
(rocksdb.auto-compaction-small-sst-file-size-threshold) when count exceeds
(rocksdb.auto-compaction-small-sst-file-num-threshold)"
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -364,6 +364,31 @@ public void setWaitOnAllFollowers(boolean val) {
)
private int rocksdbMaxOpenFiles = ROCKSDB_MAX_OPEN_FILES_DEFAULT;
+ @Config(key = "rocksdb.auto-compaction-small-sst-file",
+ defaultValue = "true",
+ type = ConfigType.BOOLEAN,
+ tags = { DATANODE },
+ description = "Auto compaction small sst files when condition is met. "
+ )
+ private boolean autoCompactionSmallSstFile = true;
+
+ @Config(key = "rocksdb.auto-compaction-small-sst-file-size-threshold",
+ defaultValue = "1MB",
+ type = ConfigType.SIZE,
+ tags = { DATANODE },
+ description = "Sst files with size smaller than threshold is a target."
+ )
+ private long autoCompactionSmallSstFileSize = 1024 * 1024;
+
+ @Config(key = "rocksdb.auto-compaction-small-sst-file-num-threshold",
+ defaultValue = "512",
+ type = ConfigType.INT,
+ tags = { DATANODE },
+ description = "Auto compaction will happen if the number of small Sst " +
+ " files exceeds this threshold."
Review Comment:
```suggestion
description = "Auto compaction will happen if the number of small SST
" +
" files exceeds this threshold."
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -364,6 +364,31 @@ public void setWaitOnAllFollowers(boolean val) {
)
private int rocksdbMaxOpenFiles = ROCKSDB_MAX_OPEN_FILES_DEFAULT;
+ @Config(key = "rocksdb.auto-compaction-small-sst-file",
+ defaultValue = "true",
+ type = ConfigType.BOOLEAN,
+ tags = { DATANODE },
+ description = "Auto compaction small sst files when condition is met. "
+ )
+ private boolean autoCompactionSmallSstFile = true;
+
+ @Config(key = "rocksdb.auto-compaction-small-sst-file-size-threshold",
+ defaultValue = "1MB",
+ type = ConfigType.SIZE,
+ tags = { DATANODE },
+ description = "Sst files with size smaller than threshold is a target."
Review Comment:
```suggestion
description = "SST files smaller than this configuration will be auto
compacted."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
