DaveTeng0 commented on PR #3812: URL: https://github.com/apache/ozone/pull/3812#issuecomment-1408088037
> Thanks @myskov for the patch. > > > some public static methods such as `getOmRpcPort` might be useful in the future (they are used only once and the patch has inlined them) > > Not only that, but it is possible that user code may call these public methods. I think it's better to deprecate them first, to be removed in some future release. hey @myskov ~ would you mind marking those methods deprecated for now and creating ticket(s) for the removal in the future? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
